[spec] Update global.get note on constant expressions #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The global.get instruction can refer to previously defined globals in addition to imported ones now. Uses of global.get in data and element segments can refer to any global.
|
I realized after pushing the first version that tables also have constraints that are different from globals (only imported globals for |
webkit-commit-queue
pushed a commit
to takikawa/WebKit
that referenced
this pull request
Nov 28, 2023
https://bugs.webkit.org/show_bug.cgi?id=264616 Reviewed by Yusuke Suzuki. The GC proposal allows constant expressions in globals to be read sequentially (previously defined globals are ok). For tables, only imported globals. For other contexts, any globals are fine. See WebAssembly/gc#481 * JSTests/wasm/gc/const-exprs.js: (async testConstExprGlobalOrdering): * Source/JavaScriptCore/wasm/WasmConstExprGenerator.cpp: (JSC::Wasm::ConstExprGenerator::getGlobal): * Source/JavaScriptCore/wasm/WasmSectionParser.cpp: (JSC::Wasm::SectionParser::parseInitExpr): Canonical link: https://commits.webkit.org/271183@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the spec has this note:
https://webassembly.github.io/gc/core/valid/instructions.html#valid-constant
I think this is outdated given that GC allows incremental validation of globals. IIUC, uses of
global.getdata and element segments are unconstrained now as well. This PR has a minimal change for this wording.