Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS API changes? #24

Closed
lars-t-hansen opened this issue Aug 16, 2021 · 5 comments
Closed

JS API changes? #24

lars-t-hansen opened this issue Aug 16, 2021 · 5 comments

Comments

@lars-t-hansen
Copy link

lars-t-hansen commented Aug 16, 2021

This proposal looks like it might need changes to the JS API, off the top of my head at least these:

  • the index type needs to be described in the memory descriptor (our prototype uses the key "index" for this)
  • the current JS API enforces the range of initial and max to be unsigned long, ie, a u32, but this proposal requires something better than that
@aardappel
Copy link
Contributor

Not familiar with the JS API design myself.. @backes did you run into this?

@backes
Copy link
Member

backes commented Aug 31, 2021

I didn't hit this yet, but the V8 implementation is not complete yet. Also, we currently still only allow up to 4GB memories, even if you use 64 bit for indexing.

But I agree that the JS API will need changes.

@sbc100
Copy link
Member

sbc100 commented Aug 19, 2022

@lars-t-hansen what do you propose for the value of "index"? The string u64 or u32 maybe?

@eqrion
Copy link
Contributor

eqrion commented Oct 11, 2022 via email

@sbc100
Copy link
Member

sbc100 commented Aug 4, 2023

I believe this is fixed by #39

@sbc100 sbc100 closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants