Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Shorten all saturating instructions to "sat" #332

Closed
ngzhian opened this issue Aug 28, 2020 · 7 comments
Closed

Shorten all saturating instructions to "sat" #332

ngzhian opened this issue Aug 28, 2020 · 7 comments
Labels

Comments

@ngzhian
Copy link
Member

ngzhian commented Aug 28, 2020

The saturating instructions spell out the word "saturate".
I propose we shorten it to "sat" to be consistent with the truncation with saturation instructions, see https://webassembly.github.io/spec/core/text/instructions.html, e.g. 饾梻饾煥饾煢.饾棈饾棆饾棊饾棁饾柤_饾棇饾柡饾棈_饾柨饾煡饾煠_饾棇.

@carlsmith
Copy link

I always thought lop and sop would have been better names for truncate and saturate, especially in an assembly language, but that kind of thing isn't really appropriate in a serious standard.

+1 for sat.

@tlively
Copy link
Member

tlively commented Sep 6, 2020

@penzn @abrown Does this sound good to you? I think this is straightforward enough that it probably doesn't need to be voted on in a meeting.

@penzn
Copy link
Contributor

penzn commented Sep 8, 2020

Sounds fine to me, and I don't think we need to vote unless there are any concerns about this.

ngzhian added a commit to ngzhian/simd that referenced this issue Sep 10, 2020
Also update the test generate file, and regenerated all test files.

Fixed WebAssembly#332.
@binji
Copy link
Member

binji commented Sep 10, 2020

Let's keep this issue open while we fix other WAT consumers too (e.g. binaryen, wabt). I'm also curious what we should do with the clang intrinsics. From the meeting last week, it sounds like we should batch these changes and do them all at once, is that right?

@tlively
Copy link
Member

tlively commented Sep 10, 2020

Yes, batching changes is always nice for Binaryen and LLVM, and I think it's ok if they lag behind a bit on the renaming. I separately opened #342 to discuss further changes to the intrinsic names.

ngzhian added a commit that referenced this issue Sep 10, 2020
Also update the test generation script, and regenerate all test files.

Adressess #332 (not closing so other tools can also use it to track their rename progress).
@ngzhian
Copy link
Member Author

ngzhian commented Mar 17, 2021

wabt is done WebAssembly/wabt#1553, llvm and wasm_simd128.h is not up to date.

nemequ added a commit to nemequ/wav that referenced this issue Mar 17, 2021
This also anticipates a similar change in the LLVM builtins.

See WebAssembly/simd#332
@ngzhian
Copy link
Member Author

ngzhian commented May 11, 2021

LLVM is updated, closing.

@ngzhian ngzhian closed this as completed May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants