Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] introduce script scopes around expensive memory tests #1699

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rossberg
Copy link
Member

Fix #1698. This tweaks the generators for bulk memory/table tests to insert (script ...) scopes around tests and extends the JS converter to turn these into block scopes.

This is likely to break existing .wast consumers that do not recognise script scopes. The simplest fix is to ignore them by treating them as equivalent to their contents.

@titzer
Copy link
Contributor

titzer commented Oct 27, 2023

Does it help to split up these tests into multiple .wasts? In general, splitting up the many large spec tests helps ergonomics of the test suite.

@rossberg
Copy link
Member Author

Personally, I'm not a big fan of having a gazillion micro test files. But in any case, these are generated, so that would require a more significant rewrite of the JS generator scripts, that somebody would have to volunteer doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JS Generator] Add scope for each wasm instance
2 participants