Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spec] Fix module context for constants #1712

Merged
merged 2 commits into from
Apr 10, 2024
Merged

[spec] Fix module context for constants #1712

merged 2 commits into from
Apr 10, 2024

Conversation

rossberg
Copy link
Member

Fix #1711.

@rossberg rossberg mentioned this pull request Nov 27, 2023
Closed
@rossberg
Copy link
Member Author

@conrad-watt, ping.

@rossberg
Copy link
Member Author

rossberg commented Apr 2, 2024

@conrad-watt, ping again.

conrad-watt
conrad-watt approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@conrad-watt conrad-watt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this will change again with the GC proposal, where global initialisers can refer to previously-declared globals, right?

@rossberg
Copy link
Member Author

Yes, that's right.

@rossberg rossberg merged commit 9e9db5c into main Apr 10, 2024
4 checks passed
@rossberg rossberg deleted the fix.1711 branch April 10, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conrad-watt conrad-watt conrad-watt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question about validation of {element, data} segments
2 participants
@rossberg @conrad-watt