[interpreter] Fix flat call_indirect #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binji
approved these changes
Mar 2, 2018
test/core/call_indirect.wast
Outdated
| @@ -80,6 +80,38 @@ | |||
| )) | |||
| ) | |||
|
|
|||
| (func | |||
There was a problem hiding this comment.
Are we still trying to keep stacky/flat stuff in stack.wast (e.g. for Binaryen)? If not, I'd rather keep it here.
There was a problem hiding this comment.
Good point, moved to stack.wast
test/core/call_indirect.wast
Outdated
| (then i32.const 0 call_indirect) | ||
| (else i32.const 0 call_indirect) | ||
| ) | ||
| (block i32.const 0 i32.const 0 call_indirect (param i32)) |
There was a problem hiding this comment.
Might be good to test some with results too.
There was a problem hiding this comment.
Added more tests, including (type $t) and multiple fields.
binji
approved these changes
Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #737.