-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wake
and ixx.wait
instructions to spec doc
#76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One design question, though: shouldn't the names of these instructions include the atomic prefix like the others?
@@ -327,6 +329,13 @@ this action conditionally, if the read value is equal to a provided comparison | |||
argument. All other :ref:`atomicops <syntax-atomicop>` have behavior of the | |||
:ref:`ibinop <syntax-ibinop>` of the same name. | |||
|
|||
The |WAKE| and |WAIT| instructions provide primitive synchronization between | |||
:ref:`threads <syntax-thread>`. The |WAIT| instructions atomically load a value | |||
from the calculated *effective address* and compare it to an expected value. If |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: no need to emphasize "effective address" here, since the defining occurrence already was above.
I suppose so. My original thought was that the |
Such visual classification would be particularly useful in the context of "compartmentalising" the language as we've discussed at the July meeting. |
Adding "atomic" is probably worth a quick poll, should be easy to get through. |
Also fix some copy-pasta
Sounds good, I'll move forward with the name change for now (since I think it's probably better), and roll back if the CG disagrees. |
@binji can you add an agenda item for this? |
The poll in the CG meeting slightly favored switching to using the |
Syntax, validation, binary and text sections are completed. Execution section is still TODO.