Switch to treating segment flags as a bitfield. NFC #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
segment_flags
branch
2 times, most recently
from
80a6e9a
to
74074ea
Compare
This is in preparation for updating to latest version reference-types proposal where there is an additional flag and they can be combined. See: WebAssembly/bulk-memory-operations#98 Also, add ERROR_IF to binary-reader.cc as logical corollary to the existing ERROR_UNLESS.
aardappel
approved these changes
Nov 18, 2019
sbc100
force-pushed
the
segment_flags
branch
from
74074ea
to
9057dc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for updating to latest version reference-types
proposal where there is an additional flag and they can be combined.
See: WebAssembly/bulk-memory-operations#98