Fix most of the spec tests #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a pretty big PR, but a lot of the bulk is just rebasing the tests. I can split it up if that would make it easier to review, though. |
The only ones that are failing are imports, exports, linking and start. Fixes: * Make sure to assign loc_ for WasmVar * Imports must occur before any definition, not just a definition of the same kind * Check that load/store alignment is not larger than natural alignment * Always check type stack at the end of the check_block; that way an empty block is still validated * Only allow one memory or table, including imports * Don't allow importing or exporting mutable globals * Loop label signature is for the fallthrough at the bottom, not the branch target. This was implemented properly in the AST checker, but not in binary-reader-interpreter * `top_type_is_any` will check if there is ANY anywhere on the type stack; previously this check did not look past the top label's type stack limit * `drop_types_for_return` may be called without having enough values on the type stack; for example, at the end of a function the ends with return * properly handle cleaning up the type stack for the interpreter when branching to the implicit function label * rename invoke -> action a few places
KarlSchimpf
approved these changes
Oct 6, 2016
| @@ -146,6 +146,7 @@ | |||
| APPEND_FIELD_TO_LIST(module, export_field, EXPORT, export_, loc_, \ | |||
There was a problem hiding this comment.
I'm curious why this file is checked in (it is a generated source file)?
There was a problem hiding this comment.
Yeah, I'd rather not, but it makes it easier for developers who don't have bison + re2c to compile. By default it is not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only ones that are failing are imports, exports, linking and start.
Fixes:
same kind
empty block is still validated
branch target. This was implemented properly in the AST checker, but
not in binary-reader-interpreter
top_type_is_anywill check if there is ANY anywhere on the typestack; previously this check did not look past the top label's type
stack limit
drop_types_for_returnmay be called without having enough values onthe type stack; for example, at the end of a function the ends with
return
branching to the implicit function label