Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_cleanup_test_output looks dangerous #81

Open
yamt opened this issue Aug 28, 2023 · 0 comments
Open

_cleanup_test_output looks dangerous #81

yamt opened this issue Aug 28, 2023 · 0 comments

Comments

@yamt
Copy link
Contributor

yamt commented Aug 28, 2023

_cleanup_test_output uses python glob with recursive=True to find files/directories to remove.
it seems very dangerous as it follows symlinks.
especially when we have a test which tries to create a symlink to "/':

unsafe fn create_symlink_to_root(dir_fd: wasi::Fd) {
// Create a symlink.
wasi::path_symlink("/", dir_fd, "symlink").expect_err("creating a symlink to an absolute path");
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant