add a dumb timeout logic #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XXX what to do for non-unix platforms?
note: the end of file change is an unrelated editor artifact. (nvi2)
yamt
added a commit
to yamt/toywasm
that referenced
this pull request
Aug 29, 2023
yamt
added a commit
to yamt/toywasm
that referenced
this pull request
Aug 29, 2023
|
@loganek please review when you have time. this is not urgent for me. |
|
Thanks for the change, and sorry for being late with the review. I'll try to get to it by end of this week. |
|
@loganek ping |
loganek
reviewed
Jan 30, 2024
|
|
||
| On a timeout, the test runner sends SIGTERM singal to the adapter process. | ||
| When receiving the signal, the adapter process should clean up and exit | ||
| as soon as possible. |
There was a problem hiding this comment.
Could you document the current timeout?
loganek
reviewed
Jan 30, 2024
| @@ -63,5 +70,5 @@ def _validate_dict(cls: Type[T], dict_config: Dict[str, Any]) -> None: | |||
| class TestCase(NamedTuple): | |||
| name: str | |||
| config: Config | |||
| result: Result | |||
| result: Union[Result | SkippedResult | TimedoutResult] | |||
There was a problem hiding this comment.
I've never seen this syntax before; IIRC it should be either Union[Result, SkippedResult, TimedoutResult] or Result | SkippedResult | TimedoutResult, see https://docs.python.org/3/library/typing.html#typing.Union
loganek
reviewed
Jan 30, 2024
| test_output = runtime.run_test(test_path, config.args, config.env, config.dirs) | ||
| try: | ||
| test_output = runtime.run_test(test_path, config.args, config.env, config.dirs) | ||
| result: Union[Result | TimedoutResult] = _validate(validators, config, test_output) |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #42
a few notes on this implementation: