Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createScriptProcessor parameter requirements #1855

Closed
rtoy opened this issue May 9, 2019 · 4 comments
Closed

createScriptProcessor parameter requirements #1855

rtoy opened this issue May 9, 2019 · 4 comments
Assignees
@rtoy
Labels
status: ready for editing
Projects
V1
Milestone
Web Audio V1

Comments

@rtoy
Copy link
Member

rtoy commented May 9, 2019 •
edited

There's an issue with the parameter descriptions in createScriptProcessor.

Both numberOfInputChannels and numberOfOutputChannels are optional, but the description doesn't say what the default value would be. It should be specified. I think the default is 1, but I couldn't find that anywhere in the spec.
@rtoy rtoy added this to Untriaged in V1 May 9, 2019
@rtoy rtoy moved this from Untriaged to In WG Discussion in V1 May 9, 2019
@rtoy rtoy added this to the Web Audio V1 milestone May 9, 2019
@rtoy
Copy link
Member Author

rtoy commented May 9, 2019

Oops. The default counts are 2 in Chrome. The default channel counts are almost always stereo.

@rtoy rtoy self-assigned this May 9, 2019
rtoy added a commit to rtoy/web-audio-api that referenced this issue May 9, 2019
@rtoy
Fix WebAudio#1855: Default values for input and output channel count …
77db531 
…for SPN

If `numberOfInputChannels` or `numberOfOutputChannels` is not
specified, use a default of 2.
@rtoy rtoy moved this from In WG Discussion to Ready for Editing in V1 May 9, 2019
@karlt
Copy link
Contributor

karlt commented May 13, 2019

2 is consistent with the webidl at https://webaudio.github.io/web-audio-api/#BaseAudioContext thanks.

@hoch
Copy link
Member

hoch commented May 14, 2019

Sort of irrelevant, but a question: should ScriptProcessorNode still be a part of the spec when it goes to REC?

@rtoy
Copy link
Member Author

rtoy commented May 14, 2019

Yes. It's deprecated, not removed. If you remove it, then every browser that implements it is wrong.

rtoy added a commit to rtoy/web-audio-api that referenced this issue May 14, 2019
@rtoy
Fix WebAudio#1855: Set default number of channels to 2 for SPN
6a85fa0 
Just say the number of channels defaults to 2 for both the input and
output.
@rtoy rtoy closed this as completed in 61cc53b May 14, 2019
@rtoy rtoy moved this from Ready for Editing to Done in V1 May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtoy rtoy

Labels
status: ready for editing
Projects
No open projects
V1
  
Done
Milestone
Web Audio V1
Development

No branches or pull requests
3 participants
@rtoy @hoch @karlt