Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABSN playback algorithm offset #1879

Closed
rtoy opened this issue May 14, 2019 · 1 comment
Closed

ABSN playback algorithm offset #1879

rtoy opened this issue May 14, 2019 · 1 comment
Assignees
@rtoy
Projects
V1

Comments

@rtoy
Copy link
Member

rtoy commented May 14, 2019

In the ABSN playback section, the first paragraph says

the following factors working in combination, which can vary dynamically during playback:

  • A starting offset, which can expressed with sub-sample precision.

It's not really clear, but I think this "offset" is the offset parameter in start(when, offset, duration). So it's not dynamically varying. Perhaps the paragraph should be rephrased and just mention that loop points and the playback rate are (obviously) dynamically changeable during playback.
@rtoy rtoy added this to Untriaged in V1 via automation May 14, 2019
@hoch
Copy link
Member

hoch commented May 16, 2019

Move "which can vary dynamically during playback" part to the second bullet point.

@hoch hoch moved this from Untriaged to Ready for Editing in V1 May 16, 2019
@hoch hoch closed this as completed in dc3b545 May 23, 2019
hoch added a commit that referenced this issue May 23, 2019
@hoch
Merge pull request #1926 from rtoy/1879-offset-in-absn-playback-algo
6d79c0a 
Fix #1879: ABSN playback algorithm offset
V1 automation moved this from Ready for Editing to Done May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtoy rtoy

Labels
None yet
Projects
No open projects
V1
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtoy @hoch