Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setOrientation description has confusing paragraph #1880

Closed
rtoy opened this issue May 14, 2019 · 1 comment
Closed

setOrientation description has confusing paragraph #1880

rtoy opened this issue May 14, 2019 · 1 comment
Assignees
@rtoy
Projects
V1

Comments

@rtoy
Copy link
Member

rtoy commented May 14, 2019

In setOrientation the third paragraph:

Describes which direction the listener is pointing in the 3D cartesian coordinate space. Both a front vector and an up vector are provided. In simple human terms, ...

doesn't really fit wit the surrounding text. This needs to be changed somehow and I didn't want to change it when looking at #1857.
@rtoy rtoy added this to Untriaged in V1 via automation May 14, 2019
@rtoy
Copy link
Member Author

rtoy commented May 14, 2019

setPosition has something similar but isn't quite so conspicuous.

rtoy added a commit to rtoy/web-audio-api that referenced this issue May 15, 2019
@rtoy
Fix WebAudio#1880: setOrientation description
e5b8a7d 
  * Apply simple fix to setOrientation and setPosition paragraphs
  * Add some very simple descriptive text for the parameters of the methods
  * Add links to the method parameters in the method descriptions.
@hoch hoch moved this from Untriaged to Ready for Editing in V1 May 16, 2019
@rtoy rtoy closed this as completed in 99fe322 May 16, 2019
V1 automation moved this from Ready for Editing to Done May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtoy rtoy

Labels
None yet
Projects
No open projects
V1
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtoy @hoch