Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active processing for Panner/Convolver/ChannelMerger #1893

Closed
rtoy opened this issue May 16, 2019 · 2 comments
Closed

Active processing for Panner/Convolver/ChannelMerger #1893

rtoy opened this issue May 16, 2019 · 2 comments
Projects

Comments

@rtoy
Copy link
Member

rtoy commented May 16, 2019

Although it is specified that nodes that are not actively processing produce a single channel of silence, we need to make sure the various nodes alloow for this.

For example, PannerNode, paragraph 3 says:

The output of this node is hard-coded to stereo (2 channels) and cannot be configured.

That's inconsistent with nodes that aren't actively processing. We should update the PannerNode, the ConvolverNode, and the ChannelMergerNode to allow for this.

@rtoy rtoy added this to Untriaged in V1 via automation May 16, 2019
@rtoy
Copy link
Member Author

rtoy commented May 17, 2019

A note in 5.3 also says convolvers output stereo all the time. This needs to be updated too.

@hoch hoch moved this from Untriaged to Ready for Editing in V1 May 30, 2019
@rtoy
Copy link
Member Author

rtoy commented Jun 3, 2019

For reference, here are the other two places:

rtoy added a commit to rtoy/web-audio-api that referenced this issue Jun 3, 2019
State that the number of chanels in the output is 1 if the node is not
actively processing any inputs.
@rtoy rtoy closed this as completed in c9818b7 Jun 4, 2019
V1 automation moved this from Ready for Editing to Done Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
V1
  
Done
Development

No branches or pull requests

1 participant