Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Funny text in PannerNode.orientationX #1894

Closed
rtoy opened this issue May 16, 2019 · 2 comments
Closed

Funny text in PannerNode.orientationX #1894

rtoy opened this issue May 16, 2019 · 2 comments
Projects
V1

Comments

@rtoy
Copy link
Member

rtoy commented May 16, 2019 •
edited
Loading

The description of PannerNode.orientationX says:

Describes the x component of the vector of the direction the audio source is pointing in 3D Cartesian coordinate space. Depending on how directional the sound is (controlled by the cone attributes), a sound pointing away from the listener can be very quiet or completely silent.

The second sentence seems out-of-place. Perhaps it should be part of the introductory paragraph for the node? it would probably need to be expanded a bit in that case.
@rtoy rtoy added this to Untriaged in V1 via automation May 16, 2019
@hoch hoch moved this from Untriaged to Ready for Editing in V1 May 30, 2019
@rtoy
Copy link
Member Author

rtoy commented May 30, 2019

Teleconf: Nice to have and simple to do.

@rtoy
Copy link
Member Author

rtoy commented May 31, 2019

I think this can probably be deleted. The first paragraph for the PannerNode links to the panning/spatialization section which has nice diagrams to describe all of this.

rtoy added a commit to rtoy/web-audio-api that referenced this issue Jun 3, 2019
@rtoy
Fix WebAudio#1894: Remove text from orientationX
606ef70 
The sentences about directional sound and sound cones is removed.
This is all described by the panning/spatialization section, which is
linked to from the PannerNode intro itself.
@rtoy rtoy closed this as completed in 5fb8063 Jun 3, 2019
V1 automation moved this from Ready for Editing to Done Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
V1
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rtoy