Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WaveShaperNode constructor says curve set is initialized to false. #1896

Closed
rtoy opened this issue May 16, 2019 · 1 comment
Closed

WaveShaperNode constructor says curve set is initialized to false. #1896

rtoy opened this issue May 16, 2019 · 1 comment
Projects
V1

Comments

@rtoy
Copy link
Member

rtoy commented May 16, 2019

The WaveShaper constructor says that the internal slot [[curve set]] is initialized to false. But if the options dictionary specifies a curve, the slot is still initialized to false. The node should initialize the slot to whether options specifies a curve or not.
@rtoy rtoy added this to Untriaged in V1 via automation May 16, 2019
@rtoy
Copy link
Member Author

rtoy commented May 21, 2019

It's also missing a link to the "initialize" section of the spec, so initialization of the node is not well-defined.

@hoch hoch closed this as completed in cefc9cf May 22, 2019
hoch added a commit that referenced this issue May 22, 2019
@hoch
Merge pull request #1923 from rtoy/1896-fix-waveshaper-constructor-algo
602db5b 
Fix #1896: Fix WaveShaperNode constructor
V1 automation moved this from Untriaged to Done May 22, 2019
@rtoy rtoy mentioned this issue Jul 28, 2020
Closed
rtoy added a commit to rtoy/web-audio-api that referenced this issue Jul 28, 2020
@rtoy
Fix WebAudio#2231; Define internal slot [[curve set]] for WaveShaperNode
3fe4751 
Defines the internal slot `[[curve set]]` for `WaveShaperNode` using
basically the text from WebAudio#1896.
@rtoy rtoy mentioned this issue Jul 28, 2020
Merged
padenot pushed a commit that referenced this issue Jul 30, 2020
@rtoy
Fix #2231; Define internal slot [[curve set]] for WaveShaperNode (#2232)
5e6595b 
Defines the internal slot `[[curve set]]` for `WaveShaperNode` using
basically the text from #1896.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
V1
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rtoy