Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WaveShaperNode curve interpolation incomplete #2082

Closed
rtoy opened this issue Oct 14, 2019 · 0 comments
Closed

WaveShaperNode curve interpolation incomplete #2082

rtoy opened this issue Oct 14, 2019 · 0 comments
Assignees
@rtoy
Projects
V1
Milestone
Web Audio V1

Comments

@rtoy
Copy link
Member

rtoy commented Oct 14, 2019

Describe the issue
In https://webaudio.github.io/web-audio-api/#dom-waveshapernode-curve, there's an algorithm showing how the interpolation of the curve works for a WaveShaperNode.

However it's incomplete. The algorithm mentioned the k'th element of the curve and how that relates to the input to compute the output. The interpolation is specified, but not how k is computed. Seems like we've dropped that somehow. It's probably pretty clear, but we should say how it's computed.
@rtoy rtoy self-assigned this Oct 21, 2019
rtoy added a commit to rtoy/web-audio-api that referenced this issue Oct 21, 2019
@rtoy
Fix WebAudio#2082: Clarify WaveShaperNode interpolation
10fe582 
Clarify the interpolation algorithm which was missing a method of how
to compute `k`.  We refine the algorithm to show how `k` is computed.
This required some small rearrangement of the computations.

This is based on how Chrome actually does the interpolation.
@rtoy rtoy added this to Untriaged in V1 via automation Oct 21, 2019
@rtoy rtoy moved this from Untriaged to In PR Review in V1 Oct 21, 2019
@rtoy rtoy added this to the Web Audio V1 milestone Oct 24, 2019
V1 automation moved this from In PR Review to Done Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtoy rtoy

Labels
None yet
Projects
No open projects
V1
  
Done
Milestone
Web Audio V1
Development

No branches or pull requests
1 participant
@rtoy