Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AudioScheduledSourceNode start algorithm incomplete #2165

Closed
rtoy opened this issue Feb 14, 2020 · 0 comments · Fixed by #2167
Closed

AudioScheduledSourceNode start algorithm incomplete #2165

rtoy opened this issue Feb 14, 2020 · 0 comments · Fixed by #2167
Assignees
@padenot
Projects
V1

Comments

@rtoy
Copy link
Member

rtoy commented Feb 14, 2020

Describe the issue
In the description of the start method for AudioScheduledSourceNode, the second step of the algorithm says:

  1. Check for any errors that must be thrown due to parameter constraints described below.

Presumably, after checking and throwing the errors, the steps should be aborted. Without saying this, it looks like we continue on to step 3.
padenot added a commit to padenot/web-audio-api that referenced this issue Feb 18, 2020
@padenot
Abort the start algorithm if argument validation failed
c4efe66 
This fixes WebAudio#2165.
@padenot padenot mentioned this issue Feb 18, 2020
Merged
@padenot padenot self-assigned this Feb 18, 2020
@padenot padenot added this to Untriaged in V1 via automation Feb 18, 2020
V1 automation moved this from Untriaged to Done Feb 18, 2020
padenot added a commit that referenced this issue Feb 18, 2020
@padenot
Abort the start algorithm if argument validation failed (#2167)
7bbfb8f 
This fixes #2165.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@padenot padenot

Labels
None yet
Projects
No open projects
V1
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Abort the start algorithm if argument validation failed padenot/web-audio-api
2 participants
@padenot @rtoy