Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect azimuth comparison in spatialization algorithm #2193

Closed
koalefant opened this issue Apr 18, 2020 · 1 comment
Closed

Incorrect azimuth comparison in spatialization algorithm #2193

koalefant opened this issue Apr 18, 2020 · 1 comment
Assignees
@rtoy
Projects
V1

Comments

@koalefant
Copy link

Change 73726d1 (Replace HTML entities in code algorithms) has broke comparison in azimuth spatialization algorithm code:

It became

// Make azimuth relative to "forward" and not "right" listener vector.
if ((azimuth <= 0) && (azimuth <= 270))

(note double less less-equal)
While previously it was:

if ((azimuth >= 0) && (azimuth <= 270))
@rtoy
Copy link
Member

rtoy commented Apr 20, 2020

Thanks for the report and a link to the offending change!

@rtoy rtoy self-assigned this Apr 24, 2020
@rtoy rtoy added this to Untriaged in V1 via automation Apr 24, 2020
@rtoy rtoy moved this from Untriaged to Ready for Editing in V1 Apr 24, 2020
rtoy added a commit to rtoy/web-audio-api that referenced this issue Apr 24, 2020
@rtoy
Fix WebAudio#2193: Fix typo in azimuth algorithm.
8edf54b 
Change `<=` to `>=` as noted by @koalefant
@rtoy rtoy moved this from Ready for Editing to In PR Review in V1 Apr 28, 2020
V1 automation moved this from In PR Review to Done Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtoy rtoy

Labels
None yet
Projects
No open projects
V1
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@padenot @rtoy @koalefant