Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies with "control thread state" #2280

Closed
karlt opened this issue Dec 3, 2020 · 2 comments · Fixed by #2312
Closed

Inconsistencies with "control thread state" #2280

karlt opened this issue Dec 3, 2020 · 2 comments · Fixed by #2312
Assignees
Projects

Comments

@karlt
Copy link
Contributor

karlt commented Dec 3, 2020

The state attribute says "its value is identical to control thread state."

Another overview also says "control thread state is the equivalent of state".

However, these two states are updated at different times in the close(), suspend(), and resume() processes.

Also, even if a constructed AudioContext is allowed to start, the control thread state remains suspended until resume() is called. This is OK because the control thread state is only ever compared with closed, so suspended and running values are equivalent.

Proposal: remove everything that says that control thread state and state are related and replace "control thread state" with a "closed flag".

@rtoy
Copy link
Member

rtoy commented Jan 8, 2021

Teleconf:

This makes sense. We'll look through and make the necessary changes.

However, I personally prefer to keep control thread state in case we find at some later date that we do need to peek at the other values. If that happens, we'll just have to undo this change anyway.

@rtoy
Copy link
Member

rtoy commented Jan 8, 2021

Se also #72, which hasn't been resolved yet, but it might change how control thread state is referenced.

@rtoy rtoy added this to Untriaged in V1 via automation Jan 8, 2021
@rtoy rtoy moved this from Untriaged to Ready for Editing in V1 Jan 8, 2021
V1 automation moved this from Ready for Editing to Done Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
V1
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants