Rework description of control thread state and rendering thread state #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtoy
approved these changes
Apr 1, 2021
…dering thread state
…nder thread state]] private slots.
padenot
force-pushed
the
2280-control-thread-state
branch
from
5fe7820
to
f2314d1
Compare
|
(simple rebase over @hoch changes for the task source) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2280. I want with Raymond's suggestion.
The first commit contains the real change. The second commit is simply a cleanup where I switch to using more bikeshed markup and `[[]]`` symbols, in line with what we do for other private slots.
I also took this opportunity to describe more formally the
stategetter.Preview | Diff