Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebIDL no longer defines "present" #2338

Closed
svgeesus opened this issue May 5, 2021 · 2 comments
Closed

WebIDL no longer defines "present" #2338

svgeesus opened this issue May 5, 2021 · 2 comments
Projects

Comments

@svgeesus
Copy link
Contributor

svgeesus commented May 5, 2021

Describe the issue

There are a bunch of links

<a href="https://heycam.github.io/webidl/#dfn-present">present</a>

but WebIDL no longer defines this so the link is broken. I traced it to this issue where they defer to the infra definition map-exists. Although the related pull request didn't seem to remove that term :(

So I believe this should be

<a href="https://infra.spec.whatwg.org/#map-exists">present</a>

I have made this change in the Proposed Rec, as we are nt allowed to have broken links. If there is a better link, we have like 24 hours to update it.

@rtoy
Copy link
Member

rtoy commented May 6, 2021

The first occurrence I looked at is Step 2 of the ConvolverNode constructor:

If buffer is present, set the buffer attribute to its value.

Both buffer link to the buffer attribute. Perhaps the first buffer is meant to be the buffer member of the ConvolverOptions dictionary? Otherwise, I can't make sense of this sentence.

But I think the link to map-exists is the right one for rest of the convolver constructor algorithm; they all talk about a dictionary member being "present" in the options dictionary. So "map-exists" makes sense.

Since you already made the change for the PR, I'm not sure how to proceed here.

@rtoy rtoy added this to Untriaged in V1 via automation May 6, 2021
@padenot
Copy link
Member

padenot commented May 27, 2021

Probably back-port here, and we're good, no ?

rtoy pushed a commit to rtoy/web-audio-api that referenced this issue Jun 2, 2021
The link
```
<a href="https://heycam.github.io/webidl/#dfn-present">present</a>
```
no longer exists and should be replaced with map-exists.  Instead of
using the suggested replacement in WebAudio#2338 of:
```
<a href="https://infra.spec.whatwg.org/#map-exists">present</a>
```
with the bikeshed-friendly:
```
<a for=map>exists</a>
```
@rtoy rtoy closed this as completed in e43a024 Jun 11, 2021
V1 automation moved this from Untriaged to Done Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
V1
  
Done
Development

No branches or pull requests

4 participants