Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in VUMeterNode sample #2359

Closed
rtoy opened this issue Jun 25, 2021 · 0 comments
Closed

Typo in VUMeterNode sample #2359

rtoy opened this issue Jun 25, 2021 · 0 comments
Labels
status: ready for editing

Comments

@rtoy
Copy link
Member

rtoy commented Jun 25, 2021 •
edited

Describe the issue

There's a typo in the VUMeterNode sample, as noted in PR #2356.

I'm just adding a bug to go with the PR so we have an issue number to make updating the ChangeLog easier.

Where Is It

See https://webaudio.github.io/web-audio-api/#vu-meter-mode, line 10 of Example 17.
@rtoy rtoy changed the title Typo in VUMeter Typo in VUMeterNode sample Jun 25, 2021
rtoy pushed a commit to rtoy/web-audio-api that referenced this issue Jun 25, 2021
Fix WebAudio#2359: Fix typo in VUMeterNode
cb97fb2 
The typo is marked as a candidate correction, and linked to WebAudio#2359 for
easy tracking.  The id is "c2359" where "c" stands for "correction",
and "2359" is the corresponding V1 issue number.  This makes it easy
to create unique ids for the links necessary for the correction.
@rtoy rtoy mentioned this issue Jun 25, 2021
Merged
@hoch hoch closed this as completed in 05ae4ec Aug 26, 2021
hoch added a commit that referenced this issue Aug 26, 2021
@hoch
Merge pull request #2360 from rtoy/2359-fix-typo-vumeter-example
207d52d 
Fix #2359: Fix typo in VUMeterNode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: ready for editing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtoy @hoch