Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioBufferSourceNode.playbackRate should be specified as k-rate and not a-rate #55

Closed
olivierthereaux opened this issue Sep 11, 2013 · 5 comments

Comments

@olivierthereaux
Copy link
Contributor

Originally reported on W3C Bugzilla ISSUE-21592 Fri, 05 Apr 2013 15:26:40 GMT
Reported by paul@paul.cx
Assigned to

Quote from the spec:

playbackRate

The speed at which to render the audio stream. The default
playbackRate.value is 1. This parameter is a-rate

WebKit implements this property as being k-rate, and I believe this is in fact just a typo in the spec.

@karlt
Copy link
Contributor

karlt commented Dec 23, 2013

Gecko also implements this as k-rate. Creating an efficient quality resampler with a different rate on each sample could be difficult, and there is no need for per-sample changes.

@joeberkovitz
Copy link
Contributor

It is not necessarily true that there is no need for per-sample changes. Consider the need to modulate the frequency of a sampled instrument recording, e.g. apply musical vibrato.

@billhofmann
Copy link
Contributor

What is the decision here? Does it require further discussion?

@joeberkovitz
Copy link
Contributor

I don't know, but it looks like k-rate is what everyone has implemented. I am finding that k-rate is sufficient for most frequency modulation in Noteflight. I think we should go with k-rate and leave fancier per-sample modulation to the realm of custom synthesis.

@padenot
Copy link
Member

padenot commented Sep 23, 2015

Yes, I think we can just close this. k-rate has been how it's done for ages now.

@joeberkovitz joeberkovitz self-assigned this Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants