Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the data model for AudioContext.createPeriodicWave #68

Closed
olivierthereaux opened this issue Sep 11, 2013 · 4 comments
Closed

Specify the data model for AudioContext.createPeriodicWave #68

olivierthereaux opened this issue Sep 11, 2013 · 4 comments

Comments

@olivierthereaux
Copy link
Contributor

Originally reported on W3C Bugzilla ISSUE-22830 Mon, 29 Jul 2013 18:48:53 GMT
Reported by Ehsan Akhgari [:ehsan]
Assigned to

We need to specify exactly what happens when you call AudioContext.createPeriodicWave. Roc's proposal was that we should copy the arrays passed into this method when it gets called and use the internal copies from that point on so that we don't race with those arrays being modified on the main thread. I support that proposal.

@olivierthereaux
Copy link
Contributor Author

Original comment by Marcus Geelnard (Opera) on W3C Bugzilla. Mon, 05 Aug 2013 13:43:36 GMT

I also support the copy behavior, it's the clearest definition.

@olivierthereaux
Copy link
Contributor Author

Original comment by Ehsan Akhgari [:ehsan] on W3C Bugzilla. Thu, 08 Aug 2013 03:21:50 GMT

Chris, how do you feel about this?

@joeberkovitz
Copy link
Contributor

See #65 which is essentially the same issue

@cwilso cwilso added this to the Web Audio Last Call 1 milestone Oct 30, 2014
@padenot
Copy link
Member

padenot commented Nov 4, 2014

Copying is fine, as I would not expect authors to call this super often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants