Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property bag for IIRFilter #701

Closed
rtoy opened this issue Jan 15, 2016 · 3 comments
Closed

Property bag for IIRFilter #701

rtoy opened this issue Jan 15, 2016 · 3 comments

Comments

@rtoy
Copy link
Member

rtoy commented Jan 15, 2016

The IIRFilter node has no attributes. To create one, the feedforward and feedback coefficients need to be specified, so these should be the names of the properties. (These are the names of the parameters for createIIRFilter.)
#696

@hoch
Copy link
Member

hoch commented Feb 16, 2016

dictionary IIRFilterOptions : AudioNodeOptions {
    sequence<double> feedforward;
    sequence<double> feedback;
};

[Constructor(AudioContext audioContext, optional IIRFilterOptions iirFilterOptions)]
partial interface IIRFilterNode {
}

@mdjp
Copy link
Member

mdjp commented Apr 7, 2016

F2F: Agreed

@mdjp mdjp added this to the Web Audio V1 milestone Apr 7, 2016
@rtoy
Copy link
Member Author

rtoy commented Jun 28, 2016

Looks right, except IIRFilterOptions can't be optional because you have to specify some filter coefficients. This also means that feedforward and feedback members of the dictionary are required.

@rtoy rtoy closed this as completed in ec0b7a2 Aug 2, 2016
rtoy added a commit that referenced this issue Aug 2, 2016
Fix #701: Add constructor for IIRFilterNode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants