Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WaveShaperNodeCurveLength): WaveShaperNode curve length limit #90

Closed
olivierthereaux opened this issue Sep 11, 2013 · 2 comments
Closed

Comments

@olivierthereaux
Copy link
Contributor

Originally reported on W3C Bugzilla ISSUE-17365 Tue, 05 Jun 2012 11:52:13 GMT
Reported by Philip Jägenstedt
Assigned to

Audio-ISSUE-79 (WaveShaperNodeCurveLength): WaveShaperNode curve length limits [Web Audio API]

http://www.w3.org/2011/audio/track/issues/79

Raised by: Philip Jägenstedt
On product: Web Audio API

https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#WaveShaperNode

The behavior is not defined when the curve is 0 or 1 values long. It would also be useful to clarify how the values are mapped to the -1 -> +1 range. The assumption seems be that the values are spread with equal spacing, such that a curve with an odd number of values has the middle value corresponding to 0 and a curve with an even number of values has the two middle values corresponding to values around 0.

Finally, is there an upper limit to the curve length? Presumably there is not.

@cwilso cwilso added this to the Web Audio Last Call 1 milestone Oct 30, 2014
@cwilso
Copy link
Contributor

cwilso commented Oct 30, 2014

I think setCurve with a curve of <2 values should throw InvalidAccessError. No upper limit to curve length. Philip's assumption from above should be documented.

@rtoy
Copy link
Member

rtoy commented Jun 24, 2015

Fixed by pull request #388.

@rtoy rtoy closed this as completed Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants