Clarify language around resuming closed AudioContexts. #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clean up fuzzy assumptions about the AudioContext class being the subject of the section in question (it applies to offline contexts to some extent).
padenot
reviewed
Jan 20, 2017
| Creating an <a>AudioContext</a> often involves creating a | ||
| high-priority thread, and using a low-latency system audio stream, | ||
| both having an impact on energy consumption. Creating more than one | ||
| <a>AudioContext</a> in a document is most of the time unnecessary. |
There was a problem hiding this comment.
This PR removes this sentence, is that intentional ?
There was a problem hiding this comment.
The removal was intentional (the language felt like overstepping) , but perhaps I overdid it. WIll reinstate.
index.html
Outdated
| it to continue to operate later by invoking <a href= | ||
| "#widl-BaseAudioContext-resume-Promise-void">resume</a>. Closing an | ||
| <a>AudioContext</a> completely releases all of its resources, after | ||
| which it cannot be used or resumed again. |
There was a problem hiding this comment.
It's allowed to release resources, not mandatory. I'd put something like:
Closing an AudioContext allows implementations to release resources
to put an emphasis on the fact that this is an implementation choice.
|
@rtoy reminder |
rtoy
reviewed
Mar 6, 2017
index.html
Outdated
| <p> | ||
| Constructing or resuming a <a>BaseAudioContext</a> subclass | ||
| involves <dfn id="acquiring">acquiring system resources</dfn>. This | ||
| means creating a high-priority thread and (for <a>AudioContext</a> |
There was a problem hiding this comment.
"high-priority thread" isn't required.
index.html
Outdated
| involves <dfn id="acquiring">acquiring system resources</dfn>. This | ||
| means creating a high-priority thread and (for <a>AudioContext</a> | ||
| only) creating a system audio stream. This operation returns when | ||
| the audio stream is ready. |
There was a problem hiding this comment.
Do we have a concept of "ready" really means? If so, a link to this would be great.
…text “readiness”
rtoy
reviewed
Mar 6, 2017
index.html
Outdated
| system audio stream. This operation returns when the audio stream | ||
| is ready. | ||
| authors to <dfn id="releasing">release system resources</dfn>, | ||
| including threads, processes and audio streams. Suspending an |
rtoy
approved these changes
Mar 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1100