Fix #1152: Define OfflineAudioContext constructor with dictionary #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nary Add new constructor for OfflineAudioContext that takes a required OfflineAudioContextOptions dictionary to specify the necessary parameters to create an offline context.
padenot
approved these changes
Mar 20, 2017
|
Thanks @padenot |
|
@padenot Are you working on better defining the existing constructor for OfflineAudioContext? If so, perhaps it's best if I don't do any more work on this until that is done. If not, then perhaps this can include all the needed bits. |
The old 3-arg constructor is defined in terms of the new 1-arg constructor, and the appropriate steps for constructing the context is given.
|
Closing until @padenot finishes the other in-progress constructor changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new constructor for OfflineAudioContext that takes a required
OfflineAudioContextOptions dictionary to specify the necessary
parameters to create an offline context.