Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the WebIDL interfaces for the new optional dictionnary defaulting #1993

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

padenot
Copy link
Member

@padenot padenot commented Jul 11, 2019

This was done by running:

sed -i 's/optional\(.*\)Options options)/optional\1Options options = {})/' index.bs

Preview | Diff

…ing.

This was done by running:

```
sed -i 's/optional\(.*\)Options options)/optional\1Options options = {})/' index.bs
```
@padenot padenot requested a review from hoch July 11, 2019 18:15
@padenot padenot self-assigned this Jul 11, 2019
@padenot
Copy link
Member Author

padenot commented Jul 11, 2019

This fixes #1989.

Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so let's merge it after fixing errors.

@padenot
Copy link
Member Author

padenot commented Jul 11, 2019

We need the correspondingbikeshed and widlparser fixes landed before we can merge this, I'll retrigger and merge when it's time.

Deps (as mentionned in whatwg/webidl#758): plinss/widlparser#39 speced/bikeshed#1491

@rtoy
Copy link
Member

rtoy commented Jul 12, 2019

This seems a bit premature if none of the required infrastructure is available.

I would propose that unless this happens in the next week or two, that this issue (and PR) get pushed to v2. Because it will be anyway if the infrastructure isn't available.

@hoch hoch added this to In PR Review in V1 Jul 12, 2019
@rtoy
Copy link
Member

rtoy commented Aug 22, 2019

Based on PR #2042, it looks like bikeshed has the necessary support for this now, so we're probably ready to land this.

@rtoy
Copy link
Member

rtoy commented Aug 22, 2019

Hmm. There are other changes in play here. Take a look at the preview and look at each constructor. There was a table listing the parameters to the constructor, and columns "Type", "Nullable" and "Optional" used to have the type and x's or checkmarks to indicate if they're nullable or optional.

The preview doesn't have these anymore. This seems like a regression in bikeshed? Missing the type is really unfortunate.

@rtoy
Copy link
Member

rtoy commented Aug 22, 2019

Filed speced/bikeshed#1511 for this.

@rtoy
Copy link
Member

rtoy commented Aug 22, 2019

We should probably wait on this since Tab says it's probably a bug. (See speced/bikeshed#1511 (comment))

@rtoy
Copy link
Member

rtoy commented Aug 23, 2019

Whatever the problem was it seems to be gone now when I build this branch locally. The tables have the right thing now.

@padenot padenot merged commit 41d1e60 into WebAudio:master Aug 29, 2019
V1 automation moved this from In PR Review to Done Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
V1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants