Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2231; Define internal slot [[curve set]] for WaveShaperNode #2232

Merged
merged 1 commit into from Jul 30, 2020
Merged

Fix #2231; Define internal slot [[curve set]] for WaveShaperNode #2232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions expected-errs.txt
View file
Open in desktop
Expand Up @@ -108,8 +108,6 @@ LINK ERROR: No 'argument' refs found for 'context' with for='WaveShaperNode/Wave
<a data-lt="context" data-link-type="argument" data-link-for="WaveShaperNode/WaveShaperNode(context, options), WaveShaperNode/constructor(context, options), WaveShaperNode/WaveShaperNode(context), WaveShaperNode/constructor(context)">context</a>
LINK ERROR: No 'argument' refs found for 'options' with for='WaveShaperNode/WaveShaperNode(context, options)'.
<a data-lt="options" data-link-type="argument" data-link-for="WaveShaperNode/WaveShaperNode(context, options), WaveShaperNode/constructor(context, options), WaveShaperNode/WaveShaperNode(context), WaveShaperNode/constructor(context)">options</a>
LINK ERROR: No 'idl' refs found for '[[curve set]]'.
{{WaveShaperNode/[[curve set]]}}
LINK ERROR: No 'argument' refs found for 'context' with for='AudioWorkletNode/AudioWorkletNode(context, name, options)'.
<a data-lt="context" data-link-type="argument" data-link-for="AudioWorkletNode/AudioWorkletNode(context, name, options), AudioWorkletNode/constructor(context, name, options), AudioWorkletNode/AudioWorkletNode(context, name), AudioWorkletNode/constructor(context, name)">context</a>
LINK ERROR: No 'argument' refs found for 'name' with for='AudioWorkletNode/AudioWorkletNode(context, name, options)'.
Expand Down
5 changes: 5 additions & 0 deletions index.bs
View file
Open in desktop
Expand Up @@ -9494,6 +9494,11 @@ Constructors</h4>
path: audionode-init.include
</pre>

Also, let <dfn attribute for="WaveShaperNode">[[curve set]]</dfn> be an internal
slot of this {{WaveShaperNode}}. Initialize this slot to <code>false</code>. If
{{WaveShaperNode/constructor(context, options)/options}} is given and specifies a
{{WaveShaperOptions/curve}}, set {{[[curve set]]}} to <code>true</code>.

<pre class=argumentdef for="WaveShaperNode/constructor(context, options)">
context: The {{BaseAudioContext}} this new {{WaveShaperNode}} will be <a href="#associated">associated</a> with.
options: Optional initial parameter value for this {{WaveShaperNode}}.
Expand Down