-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1933: Use FrozenArray for AudioWorkletProcessor process() #2250
Commits on Sep 22, 2020
-
Fix WebAudio#1933: Use FrozeArray for AudioWorkletProcessor process()
Instead of `sequence<sequence<Float32Array>>`, use `FrozenArray<FrozenArray<Float32Array>>`. Define a callback function as well.
Configuration menu - View commit details
-
Copy full SHA for 607eb07 - Browse repository at this point
Copy the full SHA 607eb07View commit details
Commits on Sep 25, 2020
-
Address review comments from karlt.
Rename AudioWorkletProcessorCallback to AudioWorletProcessCallback The third parameter is an object, not frozen array.
Configuration menu - View commit details
-
Copy full SHA for de45916 - Browse repository at this point
Copy the full SHA de45916View commit details -
Replace process() method with callback sections
Several changes here in no particular order: - Tell bikeshed that `object` is the webidl concept - Fix parameter names for the process callback (plurals, as used in the descriptions) - Rename the dfn for "Processing an input buffer" from "process" to "processing-input-buffer". - Fix up links to `process()` to point to the right place. - The old section on the process method is broken up into two sections. The main one is renaming it to "callback AudioWorkletProcessCallback". This contains most fo the main text. A subsection then describes the parameters to the callback.
Configuration menu - View commit details
-
Copy full SHA for 0366317 - Browse repository at this point
Copy the full SHA 0366317View commit details -
The callback idea fixes the errors from defining the process method.
Configuration menu - View commit details
-
Copy full SHA for 097a0ed - Browse repository at this point
Copy the full SHA 097a0edView commit details
Commits on Oct 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f14cc12 - Browse repository at this point
Copy the full SHA f14cc12View commit details -
Describe what happens to inputs/outputs if things change
Add text to say inputs/outputs are recycled unless the topology changes (number of channels, array is transferred). Then new arrays are allocated.
Configuration menu - View commit details
-
Copy full SHA for e90a8ab - Browse repository at this point
Copy the full SHA e90a8abView commit details
Commits on Oct 2, 2020
-
Still need description of how parameters are frozen.
Configuration menu - View commit details
-
Copy full SHA for cc2bef4 - Browse repository at this point
Copy the full SHA cc2bef4View commit details
Commits on Oct 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b2fdc7d - Browse repository at this point
Copy the full SHA b2fdc7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0af014 - Browse repository at this point
Copy the full SHA c0af014View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b6dc31 - Browse repository at this point
Copy the full SHA 2b6dc31View commit details -
Update implementation-report.html
Update for Safari and for Edge
Configuration menu - View commit details
-
Copy full SHA for 443e3d5 - Browse repository at this point
Copy the full SHA 443e3d5View commit details -
Update implementation-report.html
Update IDL results for newer browsers
Configuration menu - View commit details
-
Copy full SHA for 2c4f0c2 - Browse repository at this point
Copy the full SHA 2c4f0c2View commit details -
Update implementation-report.html
Update summaries for new browsers. Fails = 6573 - passes
Configuration menu - View commit details
-
Copy full SHA for 0af14fe - Browse repository at this point
Copy the full SHA 0af14feView commit details -
Configuration menu - View commit details
-
Copy full SHA for df661ef - Browse repository at this point
Copy the full SHA df661efView commit details -
Fix typo "atleast" (WebAudio#2259)
This isn't really a typo but an issue with bikeshed not leaving a space at line breaks. See speced/bikeshed#1470.
Configuration menu - View commit details
-
Copy full SHA for c7cac46 - Browse repository at this point
Copy the full SHA c7cac46View commit details -
Address WebAudio#2185: Fix duplicated IDs for decode callbacks (WebAu…
…dio#2253) * Address WebAudio#2185: Duplicate IDs for Decode callbacks The decode callbacks were multiply defining their arguments. Instead, just have the descriptions of the arguments just link back to the IDL that defines the args. * Update expected errors
Configuration menu - View commit details
-
Copy full SHA for f019a91 - Browse repository at this point
Copy the full SHA f019a91View commit details -
Fix WebAudio#2262: Clone bikeshed and install it (WebAudio#2263)
As a workaround, clone the bikeshed repo and install bikeshed from the repo. Ideally, want just want to use the version with pip3 instead of cloning the current version of bikeshed, but that's producing unexpected errors. We'll do this for now and recheck at some later date when bikeshed is updated and revert to the old version.
Configuration menu - View commit details
-
Copy full SHA for 3ed4110 - Browse repository at this point
Copy the full SHA 3ed4110View commit details -
Fix WebAudio#2257: Make channel ordering table visible in dark mode (W…
…ebAudio#2264) When using dark mode, use a different background color for the even rows of the channel ordering table so that the entries are visible. While we're at it, make the headings for the audio node properties table, the audio param values table, and the enumeration description table look a little better in dark mode. This is done by specifying a brighter green to make it a bit more legible.
Configuration menu - View commit details
-
Copy full SHA for c6030e2 - Browse repository at this point
Copy the full SHA c6030e2View commit details
Commits on Nov 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b2c9791 - Browse repository at this point
Copy the full SHA b2c9791View commit details
Commits on Nov 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 6135447 - Browse repository at this point
Copy the full SHA 6135447View commit details
Commits on Nov 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ae984bd - Browse repository at this point
Copy the full SHA ae984bdView commit details