Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1933: Use FrozenArray for AudioWorkletProcessor process() #2250

Merged
merged 21 commits into from
Nov 19, 2020

Commits on Sep 22, 2020

  1. Fix WebAudio#1933: Use FrozeArray for AudioWorkletProcessor process()

    Instead of `sequence<sequence<Float32Array>>`, use
    `FrozenArray<FrozenArray<Float32Array>>`.
    
    Define a callback function as well.
    rtoy committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    607eb07 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2020

  1. Address review comments from karlt.

    Rename AudioWorkletProcessorCallback to AudioWorletProcessCallback
    
    The third parameter is an object, not frozen array.
    rtoy committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    de45916 View commit details
    Browse the repository at this point in the history
  2. Replace process() method with callback sections

    Several changes here in no particular order:
    
    - Tell bikeshed that `object` is the webidl concept
    - Fix parameter names for the process callback (plurals, as used in the descriptions)
    - Rename the dfn for "Processing an input buffer" from "process" to "processing-input-buffer".
    - Fix up links to `process()` to point to the right place.
    - The old section on the process method is broken up into two sections.  The main one is renaming it to "callback AudioWorkletProcessCallback".  This contains most fo the main text. A subsection then describes the parameters to the callback.
    rtoy committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    0366317 View commit details
    Browse the repository at this point in the history
  3. Update expected errors

    The callback idea fixes the errors from defining the process method.
    rtoy committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    097a0ed View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Address some review comments

    rtoy committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    f14cc12 View commit details
    Browse the repository at this point in the history
  2. Describe what happens to inputs/outputs if things change

    Add text to say inputs/outputs are recycled unless the topology
    changes (number of channels, array is transferred).  Then new arrays
    are allocated.
    rtoy committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    e90a8ab View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Address some review comments

    Still need description of how parameters are frozen.
    rtoy committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    cc2bef4 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Update README.md

    svgeesus authored and rtoy committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    b2fdc7d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c0af014 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2b6dc31 View commit details
    Browse the repository at this point in the history
  4. Update implementation-report.html

    Update for Safari and for Edge
    svgeesus authored and rtoy committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    443e3d5 View commit details
    Browse the repository at this point in the history
  5. Update implementation-report.html

    Update IDL results for newer browsers
    svgeesus authored and rtoy committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    2c4f0c2 View commit details
    Browse the repository at this point in the history
  6. Update implementation-report.html

    Update summaries for new browsers. Fails = 6573 -  passes
    svgeesus authored and rtoy committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    0af14fe View commit details
    Browse the repository at this point in the history
  7. Update implementation-report.html

    Date
    svgeesus authored and rtoy committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    df661ef View commit details
    Browse the repository at this point in the history
  8. Fix typo "atleast" (WebAudio#2259)

    This isn't really a typo but an issue with bikeshed not leaving a
    space at line breaks.  See speced/bikeshed#1470.
    rtoy committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    c7cac46 View commit details
    Browse the repository at this point in the history
  9. Address WebAudio#2185: Fix duplicated IDs for decode callbacks (WebAu…

    …dio#2253)
    
    * Address WebAudio#2185: Duplicate IDs for Decode callbacks
    
    The decode callbacks were multiply defining their arguments.  Instead,
    just have the descriptions of the arguments just link back to the IDL
    that defines the args.
    
    * Update expected errors
    rtoy committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    f019a91 View commit details
    Browse the repository at this point in the history
  10. Fix WebAudio#2262: Clone bikeshed and install it (WebAudio#2263)

    As a workaround, clone the bikeshed repo and install bikeshed from the
    repo.
    
    Ideally, want just want to use the version with pip3 instead of
    cloning the current version of bikeshed, but that's producing
    unexpected errors.  We'll do this for now and recheck at some later
    date when bikeshed is updated and revert to the old version.
    rtoy committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    3ed4110 View commit details
    Browse the repository at this point in the history
  11. Fix WebAudio#2257: Make channel ordering table visible in dark mode (W…

    …ebAudio#2264)
    
    When using dark mode, use a different background color for the even
    rows of the channel ordering table so that the entries are visible.
    
    While we're at it, make the headings for the audio node properties
    table, the audio param values table, and the enumeration description
    table look a little better in dark mode.  This is done by specifying a
    brighter green to make it a bit more legible.
    rtoy committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    c6030e2 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2020

  1. Configuration menu
    Copy the full SHA
    b2c9791 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. Configuration menu
    Copy the full SHA
    6135447 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2020

  1. Some cleanups.

    rtoy committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    ae984bd View commit details
    Browse the repository at this point in the history