Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2251: Refine phrasing for "allowed to start" #2308

Merged
merged 2 commits into from Mar 25, 2021

Conversation

rtoy
Copy link
Member

@rtoy rtoy commented Mar 11, 2021

The phrasing using "delay" is confusing. Replace it with "disallow" which reflects more precisely what happens. When a context is not allowed to start, it isn't really "delayed"; it can only start under specific actions with a user-gesture.


Preview | Diff

The phrasing using "delay" is confusing.  Replace it with "disallow"
which reflects more precisely what happens.  When a context is not
allowed to start, it isn't really "delayed"; it can only start under
specific actions with a user-gesture.
@rtoy rtoy requested a review from mdjp March 11, 2021 18:53
@padenot
Copy link
Member

padenot commented Mar 23, 2021

Why not indeed.

@hoch hoch self-requested a review March 24, 2021 21:34
@rtoy rtoy merged commit a7556a5 into WebAudio:main Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants