Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeError is thrown only for negative cancelTime #2352

Merged
merged 5 commits into from Aug 26, 2021

Conversation

rtoy
Copy link
Member

@rtoy rtoy commented Jun 4, 2021

Fixes WebAudio/web-audio-api-v2#127 by removing the text that says a
RangeError is also thrown for non-finite values. That's not
possible because the type of cancelTime is double, not
unrestricted double. Non-finite values are handled at a higher
level before these methods even see the number.


Preview | Diff

@rtoy rtoy marked this pull request as draft June 4, 2021 16:32
@rtoy rtoy requested a review from svgeesus June 4, 2021 16:32
@rtoy
Copy link
Member Author

rtoy commented Jun 4, 2021

@svgeesus My guess on how a candidate correction would work. I just copied fixup.js from https://github.com/w3c/tr-design/issues that is mentioned in http://fantasai.inkedblade.net/style/design/w3c-restyle/2020/readme.

I have no idea if that's the right thing to do or not. Also, for the id, I used c127, where 127 is the issue number of the thing we're fixing.

And finally, the toggle buttons change both the text in cancelAndHoldAtTime and cancelScheduledValues. Perhaps that's not the best, even though it is one issue.

@padenot
Copy link
Member

padenot commented Jun 7, 2021

The Web Audio API looks good, in any case.

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't the changed lines need to have ins and del round them?

@rtoy
Copy link
Member Author

rtoy commented Jun 11, 2021

There are no insertions so no <ins>. But there are deletions marked by <del>. You have to scroll way over to the right to see it where we delete the phrase "or is not a finite number".

I see now that we don't need to include fixup.js in our repo. We can just load it up from w3c.org as you did in the audio eq cookbook note.

@rtoy rtoy marked this pull request as ready for review July 8, 2021 15:32
@rtoy
Copy link
Member Author

rtoy commented Jul 8, 2021

Need #2363 to be merged first now since that PR has all the bits needed, including adding a change log entry

@hoch
Copy link
Member

hoch commented Aug 12, 2021

TODO: needs rebase.

@hoch hoch requested a review from padenot August 12, 2021 16:06
@hoch hoch self-assigned this Aug 12, 2021
Raymond Toy and others added 4 commits August 26, 2021 14:09
Fixes WebAudio/web-audio-api-v2#127 by removing the text that says a
`RangeError` is also thrown for non-finite values.  That's not
possible because the type of `cancelTime` is `double`, not
`unrestricted double`.  Non-finite values are handled at a higher
level before these methods even see the number.
@padenot
Copy link
Member

padenot commented Aug 26, 2021

@hoch: I've rebased this while I was at it.

@hoch hoch merged commit ab28970 into WebAudio:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cancelScheduledValues and cancelAndHoldAtTime throws RangeError for non-finite
4 participants