New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RangeError is thrown only for negative cancelTime #2352
Conversation
@svgeesus My guess on how a candidate correction would work. I just copied fixup.js from https://github.com/w3c/tr-design/issues that is mentioned in http://fantasai.inkedblade.net/style/design/w3c-restyle/2020/readme. I have no idea if that's the right thing to do or not. Also, for the id, I used c127, where 127 is the issue number of the thing we're fixing. And finally, the toggle buttons change both the text in cancelAndHoldAtTime and cancelScheduledValues. Perhaps that's not the best, even though it is one issue. |
The Web Audio API looks good, in any case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't the changed lines need to have ins and del round them?
There are no insertions so no I see now that we don't need to include fixup.js in our repo. We can just load it up from w3c.org as you did in the audio eq cookbook note. |
Need #2363 to be merged first now since that PR has all the bits needed, including adding a change log entry |
TODO: needs rebase. |
Fixes WebAudio/web-audio-api-v2#127 by removing the text that says a `RangeError` is also thrown for non-finite values. That's not possible because the type of `cancelTime` is `double`, not `unrestricted double`. Non-finite values are handled at a higher level before these methods even see the number.
b9a0760
to
7e462d0
Compare
@hoch: I've rebased this while I was at it. |
Fixes WebAudio/web-audio-api-v2#127 by removing the text that says a
RangeError
is also thrown for non-finite values. That's notpossible because the type of
cancelTime
isdouble
, notunrestricted double
. Non-finite values are handled at a higherlevel before these methods even see the number.
Preview | Diff