Define oscillator phases for the predefined types. #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </div> | ||
| <div id="oscillatorSquare-OscillatorNode-section" class="section"> | ||
| <h4 id="oscillatorSquare-OscillatorNode">4.23.3.2 "square"</h3> | ||
| The waveform for the square wave oscillator is 1 for 0<= t < π and -1 for -π < t < 0. |
There was a problem hiding this comment.
s/</</g and also other occurences. Plus spaces around binary operators.
There was a problem hiding this comment.
Did you mean something else? The subst you list is a no-op. Are you saying I should replace < with the appropriate HTML entity?
There was a problem hiding this comment.
Yes, I think github replaced ampersand-g-t-semicolon by <. Sorry about that.
|
This PR is the result of a group resolution at the 2013-11-07 teleconference. Please apply/merge whenever convenient. |
o Replace < with appropriate HTML entities. o Add some text to say these are idealized waveforms o Add link to Oscillator Types section from Oscillator Node Interface section.
|
Current spec draft addresses this with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the oscillator waveform (and hence the phase) for each of the predefined oscillator types.
HTML markup almost certainly needs reviewing in addition to the actual text.