Refactor to ReSpec #272
Closed
Refactor to ReSpec #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c04f235.
Make the nominal range for the `sampleRate` argument of AudioContext.createBuffer a normative requirement, and fix the exception thrown.
|
This looks good to me, although I think when merging it would be good to group together the ReSpec refactorings separately from the commits that fix other, unrelated issues. |
|
Indeed. I'll properly separate the spec fixes from the refactor, rebase, and update this PR so we can merge. |
|
We can close this, the refactor has been merged in #289. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (big) branch refactors the whole spec to use ReSpec, instead of not using anything, which will ease editing, and provide nice cross-references, handles normative and informative references, markup for WebIDL, and a bunch of other goodies.
It can be previewed at http://padenot.github.io/web-audio-api
This is simply a port, the content is the same, but it would be great if people could double check.
I agree that there could be more crossrefs and the like, this is merely a first step towards a spec that is nice to use. Adding more linkable content in a maintainable fashion will be way easier and can come after.