Specify exponential ramp behavior when previous value is 0 #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify what happens if the previous event value is 0. We also explicitly allow v0 and v1 to both be negative (the formula is well-defined in this case). If an error is thrown, the previous value is propagated. Fixes WebAudio#612.
| time. A NotSupportedError exception MUST be thrown if this | ||
| value is less than or equal to 0, or if the value at the time | ||
| of the previous event is less than or equal to 0. | ||
| time. A NotSupportedError exception MUST be thrown if any |
There was a problem hiding this comment.
<code> around the exception name.
There was a problem hiding this comment.
Ok. Are we going to do that everywhere else in the document? We don't do that anywhere right now.
There was a problem hiding this comment.
Yeah I think I have a patch that does it lying around in a branch.
There was a problem hiding this comment.
Although I did this in this patch, couldn't we do this the same way that "MUST" is magically highlighted (by respec)?
padenot
added a commit
that referenced
this pull request
Dec 9, 2015
Specify exponential ramp behavior when previous value is 0
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 28, 2023
…nd V1 have opposite signs or V0 is zero r=padenot WebAudio/web-audio-api#624 Depends on D189101 Differential Revision: https://phabricator.services.mozilla.com/D189204
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 29, 2023
…pposite signs or V0 is zero WebAudio/web-audio-api#624 Depends on D189101 Differential Revision: https://phabricator.services.mozilla.com/D189204 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1458045 gecko-commit: 52f0910d6e377784c88b639c006d8790b027cee4 gecko-reviewers: padenot
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 29, 2023
…pposite signs or V0 is zero WebAudio/web-audio-api#624 Depends on D189101 Differential Revision: https://phabricator.services.mozilla.com/D189204 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1458045 gecko-commit: 52f0910d6e377784c88b639c006d8790b027cee4 gecko-reviewers: padenot
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Sep 29, 2023
…nd V1 have opposite signs or V0 is zero r=padenot WebAudio/web-audio-api#624 Depends on D189101 Differential Revision: https://phabricator.services.mozilla.com/D189204 UltraBlame original commit: 52f0910d6e377784c88b639c006d8790b027cee4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 29, 2023
…nd V1 have opposite signs or V0 is zero r=padenot WebAudio/web-audio-api#624 Depends on D189101 Differential Revision: https://phabricator.services.mozilla.com/D189204 UltraBlame original commit: 52f0910d6e377784c88b639c006d8790b027cee4
ErichDonGubler
pushed a commit
to ErichDonGubler/firefox
that referenced
this pull request
Sep 30, 2023
…nd V1 have opposite signs or V0 is zero r=padenot WebAudio/web-audio-api#624 Depends on D189101 Differential Revision: https://phabricator.services.mozilla.com/D189204
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Sep 30, 2023
…nd V1 have opposite signs or V0 is zero r=padenot WebAudio/web-audio-api#624 Depends on D189101 Differential Revision: https://phabricator.services.mozilla.com/D189204 UltraBlame original commit: 52f0910d6e377784c88b639c006d8790b027cee4
Lightning00Blade
pushed a commit
to Lightning00Blade/wpt
that referenced
this pull request
Dec 11, 2023
…pposite signs or V0 is zero WebAudio/web-audio-api#624 Depends on D189101 Differential Revision: https://phabricator.services.mozilla.com/D189204 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1458045 gecko-commit: 52f0910d6e377784c88b639c006d8790b027cee4 gecko-reviewers: padenot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify what happens if the previous event value is 0. We also
explicitly allow v0 and v1 to both be negative (the formula is
well-defined in this case).
If an error is thrown, the previous value is propagated.
Fixes #612.