Fix #697: AudioNode channel options dictionary #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 28, 2016 11:09
Add the AudioNodeChannelOptions dictionary that can be inherited by most dictionaries for the AudioNode constructors.
| @@ -2733,6 +2733,29 @@ <h2 id="OfflineAudioCompletionEvent"> | |||
| </dd> | |||
| </dl> | |||
| <section> | |||
| <h2>Dictionaries</h2> | |||
| <dl title="dictionary AudioNodeChannelOptions" class="idl"> | |||
There was a problem hiding this comment.
Maybe the dictionary name should just be AudioNodeOptions instead of AudioNodeChannelOptions?
This was referenced Jul 31, 2016
|
After reviewing a number of the constructor PRs I feel strongly that |
|
Yes, I think AudioNodeOptions should probably be the base dictionary for AudioWorkletNodeOptions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the AudioNodeChannelOptions dictionary that can be inherited by
most dictionaries for the AudioNode constructors.