Polishing AudioWorkletGlobalScope section #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or the regestiration process
|
@bfgeek Could you take a look at the refined sections? (The concepts + AudioWorkletGlobalScope) |
| <a>AudioWorkletNode</a>. | ||
| </dd> | ||
| <dt> | ||
| VoidFunction audioWorkletProcessorCtor |
There was a problem hiding this comment.
Call this arg processorCtor to reconcile it with the above algorithmic description
| <a>AudioWorkletProcessor</a>. | ||
| </p> | ||
| <p> | ||
| <a>AudioWorkletGlobalScope</a> has a <dfn>node name to processor |
There was a problem hiding this comment.
You mark "node name to processor definition map" as a definition, but I don't see how this is defined in any way here. I think you need to expand this somehow if you really want to define this here.
There was a problem hiding this comment.
I've added a short description about it.
| agent must run the following steps: | ||
| </p> | ||
| <ol> | ||
| <li>If the <code><em>name</em></code> exists as a key in the | ||
| <a>node name to processor definition map</a>, throw a | ||
| <code>NotSupportedError</code> and abort all these steps. | ||
| <code>NotSupportedError</code> and abort all these steps because |
|
@joeberkovitz @padenot Is there any more to do here? |
|
lgtm |
This was referenced Sep 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://hoch.github.io/web-audio-api/#AudioWorkletGlobalScope
registerProcessor()method in the ECMA script style.