Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Message" event needs to be renamed to "MIDIMessage". #50

Closed
cwilso opened this issue Apr 20, 2013 · 4 comments
Closed

"Message" event needs to be renamed to "MIDIMessage". #50

cwilso opened this issue Apr 20, 2013 · 4 comments
Assignees
@cwilso

Comments

@cwilso
Copy link
Contributor

cwilso commented Apr 20, 2013

There's already a "message" event for receivers of postMessage()-sent data, and this will get confusing. Rename to "midi"? "midimessage"?
@ghost ghost assigned cwilso Apr 20, 2013
@toyoshim
Copy link
Contributor

Hum... WebSocket also have another "message" event.
"close" is conflicted between WebSocket and Notification, too.

If we should avoid name conflict, I prefer "midimessage" though this is a little long word.

cwilso added a commit that referenced this issue Apr 26, 2013
@cwilso
Renames, constructors for events.
f79baeb 
This fixes issue #51, issue #50, and issue #1.
@cwilso
Copy link
Contributor Author

cwilso commented Apr 26, 2013

Fixed.

@cwilso cwilso closed this as completed Apr 26, 2013
@jussi-kalliokoski
Copy link
Member

Can a MIDIPort really ever be a receiver of postMessage messages so that these would conflict?

@marcoscaceres
Copy link
Contributor

Yeah, I can't really think how to wire that up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwilso cwilso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cwilso @jussi-kalliokoski @toyoshim @marcoscaceres