Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Peripherals now broadcast their service UUID. #36

Merged
merged 1 commit into from May 6, 2015
Merged

Peripherals now broadcast their service UUID. #36

merged 1 commit into from May 6, 2015

Conversation

g-ortuno
Copy link
Contributor

@g-ortuno g-ortuno commented May 5, 2015

With this change the Peripheral App broadcasts the Service UUID of the Peripheral chosen.

Review on Reviewable

@g-ortuno
Copy link
Contributor Author

g-ortuno commented May 5, 2015

@scheib: please review

@scheib
Copy link
Contributor

scheib commented May 5, 2015

LGTM

Reviewed files:

  • app/src/main/java/io/github/webbluetoothcg/bletestperipheral/BatteryServiceFragment.java @ r1
  • app/src/main/java/io/github/webbluetoothcg/bletestperipheral/HeartRateServiceFragment.java @ r1
  • app/src/main/java/io/github/webbluetoothcg/bletestperipheral/Peripheral.java @ r1
  • app/src/main/java/io/github/webbluetoothcg/bletestperipheral/ServiceFragment.java @ r1

Comments from the review on Reviewable.io

g-ortuno added a commit that referenced this pull request May 6, 2015
@g-ortuno
Merge pull request #36 from g-ortuno/broadcast-service-uuid
cb6787f 
Peripherals now broadcast their service UUID.
@g-ortuno g-ortuno merged commit cb6787f into WebBluetoothCG:master May 6, 2015
@g-ortuno g-ortuno deleted the broadcast-service-uuid branch July 1, 2016 18:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@g-ortuno @scheib