Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maplike handling is really weird #340

Closed
bzbarsky opened this issue Dec 12, 2016 · 3 comments
Closed

maplike handling is really weird #340

bzbarsky opened this issue Dec 12, 2016 · 3 comments

Comments

@bzbarsky
Copy link

There are various parts of this spec that attempt to define what the "map entries" are for maplikes in terms of a Map. But maplikes already have a Map whose [[MapData]] is defined to be the "map entries". See https://heycam.github.io/webidl/#es-maplike

So whatever you're doing with [[data]] right now should instead be done by manipulating the [[BackingMap]], I would think. And you need to specify exactly how you manipulate it, of course.

@jyasskin
Copy link
Member

I don't know why I missed the [[BackingMap]] object that's available for this. Fix coming up.

@jyasskin
Copy link
Member

Oh, maybe I was trying to specify against the language-independent maplike spec, which says that "Prose accompanying the interface can describe how the map entries of an object change.", instead of the ES binding, which provides [[BackingMap]]. I'll still send the change to use the ES-specific slots, since I'm assuming ES elsewhere.

jyasskin added a commit to jyasskin/web-bluetooth-1 that referenced this issue Jan 20, 2017
Instead of a custom [[data]] slot that also holds an EcmaScript Map.

Fixes WebBluetoothCG#340
jyasskin added a commit that referenced this issue Jan 24, 2017
Instead of a custom [[data]] slot that also holds an EcmaScript Map.

Fixes #340
@bzbarsky
Copy link
Author

You skipped the "you need to specify exactly how you manipulate it, of course" bit. Filed #351 on that, I guess...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants