Add the GATT blacklist. #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <li> | ||
| If <var>line</var> consists of a <a>valid UUID</a>, a space (U+0020), | ||
| and one of the tokens "<code>exclude-reads</code>" or "<code>exclude-writes</code>", | ||
| add a mapping from that UUID, to the token. |
There was a problem hiding this comment.
Previous block mentions adding a mapping to result. This block likely should mention 'result' as well, or perhaps have 3 maps. To be very precise language should indicate what happens when a UUID appears multiple times with different tokens.
There was a problem hiding this comment.
Done, still with a single map.
|
LGTM |
|
Thanks. I'm going to wait to merge this until WebBluetoothCG/registries#1 is ready, so the spec never has a broken link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24.
Demo at https://rawgit.com/jyasskin/web-bluetooth-1/blacklists/index.html. The registry PR is at WebBluetoothCG/registries#1. @scheib @marcoscaceres