Unify the BluetoothUUID.get* algorithms. #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyasskin
force-pushed
the
unify-uuid-algorithms
branch
from
6bb4110
to
ca4a89e
Compare
jyasskin
changed the title
| @@ -2918,7 +2935,8 @@ | |||
| return <var>name</var> and abort these steps. | |||
| </li> | |||
| <li> | |||
| If <code>org.bluetooth.service.<var>name</var></code> appears in [[!BLUETOOTH-ASSIGNED-SERVICES]], | |||
There was a problem hiding this comment.
I think this works, but... it's a touch odd to mix variables and the '.' literal this way. An alternative would be something like: If the string prefix + "." + name appears in...
|
LGTM; Optional noted string concatenation comment. |
jyasskin
added a commit
that referenced
this pull request
Jul 30, 2015
Unify the BluetoothUUID.get* algorithms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo at https://rawgit.com/jyasskin/web-bluetooth-1/unify-uuid-algorithms/index.html#standardized-uuids