Mark internal slots that the spec always initializes. #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the " |
|
Yep. Any ideas for how to say that more clearly? |
jyasskin
force-pushed
the
mark-always-initialized-fields
branch
from
de3e7ca
to
cce75de
Compare
|
Can't think of anything less verbose 😞 Is that what's usually used in specs? |
|
We're in uncharted territory here. https://streams.spec.whatwg.org/ is the only spec I know of that uses these tables, and it doesn't initialize any slots there. @domenic, any suggestions? |
|
I could imagine |
|
Maybe just "set in prose" or "always set in prose"? I think any of these are reasonable. |
Marking them instead of saying their initial value is `undefined`, makes it easier to see if I accidentally introduce an uninitialized path.
jyasskin
force-pushed
the
mark-always-initialized-fields
branch
from
cce75de
to
4ac26da
Compare
|
I picked "always set in prose". |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking them instead of saying their initial value is
undefined, makesit easier to see if I accidentally introduce an uninitialized path.
Preview at https://api.csswg.org/bikeshed/?url=https://github.com/jyasskin/web-bluetooth-1/raw/mark-always-initialized-fields/index.bs#dom-bluetoothdevice-context-slot