Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put nice boxes around each algorithm. #286

Merged
merged 1 commit into from Sep 6, 2016

Conversation

jyasskin
Copy link
Member

@jyasskin jyasskin commented Sep 3, 2016

Definitions tend to be a bunch of text that flows imperceptibly into the
next definition. These boxes make it easier to know where to take a
breath.

Preview at https://api.csswg.org/bikeshed/?url=https://raw.githubusercontent.com/jyasskin/web-bluetooth-1/boxed-algorithms/index.bs

@tabatkins, what do you think?

Definitions tend to be a bunch of text that flows imperceptibly into the
next definition. These boxes make it easier to know where to take a
breath.
@scheib
Copy link
Contributor

scheib commented Sep 4, 2016

Looks like good rounded boxes to me.

On Fri, Sep 2, 2016 at 5:48 PM, Jeffrey Yasskin notifications@github.com
wrote:

Definitions tend to be a bunch of text that flows imperceptibly into the
next definition. These boxes make it easier to know where to take a
breath.

Preview at https://api.csswg.org/bikeshed/?url=https://raw.
githubusercontent.com/jyasskin/web-bluetooth-1/boxed-algorithms/index.bs

@tabatkins https://github.com/tabatkins, what do you think?

You can view, comment on, or merge this pull request online at:

#286
Commit Summary

  • Put nice boxes around each algorithm.

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#286, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAXnm1sArAHZr1bI818nR8mExaYYvLmdks5qmMPxgaJpZM4J0Lyu
.

@tabatkins
Copy link

Oh gosh, I love it. Subtle but useful for breaking up large runs of algorithms!

@jyasskin jyasskin merged commit 054cbb6 into WebBluetoothCG:master Sep 6, 2016
@jyasskin jyasskin deleted the boxed-algorithms branch September 6, 2016 23:46
jyasskin added a commit that referenced this pull request Sep 8, 2016
This reverts commit 054cbb6 now that
Bikeshed includes this style by default as of
speced/bikeshed@befeb4b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants