Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "non-null" with "not null" #396

Merged
merged 1 commit into from May 9, 2018

Conversation

reillyeon
Copy link
Contributor

Bikeshed compilation fails when encountering the former with,

"Unknown inline tag: non-null"

Replacing this with "not null" does not change the meaning.

@reillyeon reillyeon requested a review from jyasskin May 9, 2018 17:41
Bikeshed compilation fails when encountering the former with,

"Unknown inline tag: non-`null`"

This is caused by a new experimental Bikeshed feature.
Copy link
Member

@jyasskin jyasskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, @tabatkins, is this a Bikeshed bug?

@reillyeon
Copy link
Contributor Author

Tab acknowledges that this was caused by a change to Bikeshed. They suggested I replace the text with non-null instead and updated this pull request to do so.

@reillyeon reillyeon merged commit be1bbc0 into WebBluetoothCG:master May 9, 2018
@reillyeon reillyeon deleted the non_null branch May 9, 2018 17:46
@tabatkins
Copy link

It's caused by a new (currently undocumented while it's experimental) feature that makes Bikeshed more extensible by outside scripts, by making foo`bar` (tagged code spans) a special thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants