Migration to new version of flutter and dart #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
Looks good. However it looks like we have a couple files here that probably shouldn't be checked into git. This, along with general reorganizing of the repository can be a separate issue in itself. |
ikjot-2605
reviewed
Dec 21, 2021
ikjot-2605
reviewed
Dec 21, 2021
ikjot-2605
reviewed
Dec 21, 2021
| watcher:file:///C:/Users/Ikjot%20Singh/AppData/Local/Pub/Cache/hosted/pub.dartlang.org/watcher-0.9.7+15/lib/ | ||
| web_socket_channel:file:///C:/Users/Ikjot%20Singh/AppData/Local/Pub/Cache/hosted/pub.dartlang.org/web_socket_channel-1.2.0/lib/ | ||
| yaml:file:///C:/Users/Ikjot%20Singh/AppData/Local/Pub/Cache/hosted/pub.dartlang.org/yaml-2.2.1/lib/ | ||
| # This file is deprecated. Tools should instead consume |
|
@CommanderAstern make the aforementioned changes and push a commit. |
|
Instead of just removing them, it would make more sense to add them to the gitignore as well |
CommanderAstern
commented
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the necessary changes for migration to the new versions of flutter and dart