Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeating inputing newline character makes cursor exceeds the bottom range. #61

Closed
Ziqi-Yang opened this issue Oct 23, 2023 · 6 comments · Fixed by #63
Closed

Repeating inputing newline character makes cursor exceeds the bottom range. #61

Ziqi-Yang opened this issue Oct 23, 2023 · 6 comments · Fixed by #63
Assignees

Comments

@Ziqi-Yang
Copy link

Ziqi-Yang commented Oct 23, 2023

demo:
https://codepen.io/ziqi-yang/pen/rNPNgeO

used framework: code-input with prism.js
code input enabled plugins: Indent
prism.js enabled plugins: prism-autoloader prism-line-numbers

description:
In chromium (my version: Chromium 118.0.5993.88 Arch Linux), when you hit "Enter" repeatedly, you can see the cursor exceed the bottom range of code-input, then you need to scroll to the end or input some characters other than "Enter". In firefox developer version 119.0b9, the behavior seems fine.

caused reason:
font-size: 20px; style for code-input

@WebCoder49
Copy link
Owner

Thanks for this very detailed description - I should be able to implement and test the fix by this weekend. It's an amazing idea to put a CodePen demo!

@WebCoder49
Copy link
Owner

If you want to contribute a fix via a pull request, please let me know; otherwise I will implement it.

@Ziqi-Yang
Copy link
Author

Thank you for your invitation <3 ! However, I'm not every familiar with both of the two libraries (also front end XD). It can be predicted that tons of times may be spent into fix it and I just haven't that time right now. Thank you.

@WebCoder49
Copy link
Owner

Thank you for your invitation <3 ! However, I'm not every familiar with both of the two libraries (also front end XD). It can be predicted that tons of times may be spent into fix it and I just haven't that time right now. Thank you.

That makes sense - I have always been wanting to contribute to some other people's projects but just can't find time!

@WebCoder49 WebCoder49 self-assigned this Oct 24, 2023
@WebCoder49 WebCoder49 linked a pull request Oct 24, 2023 that will close this issue
@WebCoder49
Copy link
Owner

@Ziqi-Yang, thank you again for your contribution; it has now been released in version 2.1.0. You can use the code you already have but please change any instances of 2.0 to 2.1.

Have a great week!

@Ziqi-Yang
Copy link
Author

Thanks, you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants